feat(workspace): Distribute pipeline, not providers #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
added
K-feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
reviewed
Oct 19, 2024
refcell
reviewed
Oct 19, 2024
refcell
reviewed
Oct 19, 2024
refcell
reviewed
Oct 19, 2024
|
I'd also like to get this in first: #713 |
clabby
force-pushed
the
cl/rethink-providers
branch
from
c817d72
to
2e88e14
Compare
refcell
approved these changes
Oct 19, 2024
clabby
force-pushed
the
cl/rethink-providers
branch
from
3e59c5a
to
ba3c337
Compare
clabby
force-pushed
the
cl/rethink-providers
branch
from
ba3c337
to
aed7355
Compare
Merged
fakedev9999
pushed a commit
to fakedev9999/kona
that referenced
this pull request
Nov 5, 2024
* feat(workspace): Distribute pipeline, not providers * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Experiment to distribute
DerivationPipelinetypes, askona-providers-alloyis doing today. Our abstractions are a bit off right now, withkona-providersholding traits specific tokona-derive, without ever needing to be used alongside it. However,kona-providers-alloyis already following a great pattern by distributing the pipeline itself with a constructor for the configuration asnew_online_pipeline, as the abstractions intended.This pattern keeps cyclical dependencies away, and because we're distributing the pipeline, there's no real need for
kona-providers. We can also extend this pattern further, with a good cleanup of the oracle-backed pipeline into a newkona-derive-oraclecrate.This is also how modifications like alt DA intend to ship their pipeline type variants as well.